bevy_material #22426
bevy_material #22426
Conversation
atlv24
added
A-Rendering
alice-i-cecile
added
the
M-Release-Note
|
@atlv24 is this ready for review? You've added the label but it's still in draft mode :) |
|
the label is "Needs Review" not "Ready for Review" :P It is reviewable, but i recommend reviewing and letting char's PR merge first. |
Love how simple this is! |
|
Yeah im pretty happy with the diff being 1,227 additions and 607 deletions, and the majority of the additions are license files and the new tomls |
|
I really appreciate all the exploratory work you did in this space btw @Zeophlite ! It was very useful for determining where we needed another "cut" so to speak to make the crate fall out more cleanly. |
…e, bind_group_layout_entries
atlv24
added
S-Ready-For-Final-Review
IceSentry
left a comment
IceSentry
left a comment
There was a problem hiding this comment.
That was way smaller than I expected LGTM
alice-i-cecile
left a comment
alice-i-cecile
left a comment
There was a problem hiding this comment.
Needs a release note stub: this is an important initiative that we should call out.
alice-i-cecile
added
the
M-Migration-Guide
alice-i-cecile
left a comment
alice-i-cecile
left a comment
There was a problem hiding this comment.
We've agreed to do a release note in a follow-up PR, so merging now.
…material` when building docs (#22522) # Objective - Add a fix for currently failing Deploy Docs Action. [Example Log is here](https://github.com/bevyengine/bevy/actions/runs/20974377798/job/60285550096) - Happening on main since #22426, It appears `bevy_material` is using `#[doc(fake_variadic)]` in a module, but doc builds for the crate aren’t building correctly. It suggests `help: add `#![feature(rustdoc_internals)]` to the crate attributes to enable` ## Solution - Copy some configuration into `bevy_material` that is already used in other bevy crates that have `#[doc(fake_variadic)]`, e.g. `bevy_math` https://github.com/bevyengine/bevy/blob/main/crates/bevy_math/src/lib.rs#L2-L10 which adds the `rustdoc_internals` feature when building docs - I added the icon stuff while I was at it since that seems to be in other lib.rs files as well ## Testing I did not test this, but this seems to be a solved problem already for the other crates
6 participants
Objective
MaterialPropertiesfrombevy_pbrtobevy_material#21543 on top of More fully type erase all pbr types from specialization #22408, you can view a clean diff here: https://github.com/tychedelia/bevy/compare/type-erase-more-materials...atlv24:ad/material2?expand=1Solution
Testing